Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring: export collector timeout as prometheus config #1300

Merged
merged 2 commits into from
Jan 22, 2025
Merged

monitoring: export collector timeout as prometheus config #1300

merged 2 commits into from
Jan 22, 2025
+30 −9

Conversation

GeorgeTsagk
Copy link
Member

@GeorgeTsagk GeorgeTsagk commented Jan 14, 2025 •
edited
Loading

This PR exports the prometheus collector timeout as a prometheus config parameter.

With this timeout we will be able to observe values on our loadtest tapds for longer periods, as the timeout will be harder to reach.

@GeorgeTsagk GeorgeTsagk self-assigned this Jan 14, 2025
@coveralls
Copy link

coveralls commented Jan 14, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12904784404

Details

  • 0 of 10 (0.0%) changed or added relevant lines in 5 files are covered.
  • 32 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.004%) to 40.769%
Changes Missing Coverage Covered Lines Changed/Added Lines %
monitoring/asset_balances_collector.go 0 1 0.0%
monitoring/asset_collector.go 0 1 0.0%
monitoring/db_collector.go 0 1 0.0%
monitoring/config.go 0 3 0.0%
monitoring/prometheus.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
tapchannel/aux_leaf_signer.go 2 43.08%
commitment/tap.go 2 84.32%
asset/asset.go 2 77.13%
universe/interface.go 4 51.95%
tapdb/universe.go 4 80.91%
asset/mock.go 4 92.57%
tapchannel/aux_invoice_manager.go 6 83.25%
tapgarden/caretaker.go 8 68.87%
Totals Coverage Status
Change from base Build 12893024407: 0.004%
Covered Lines: 26661
Relevant Lines: 65395
💛 - Coveralls

Roasbeef
Roasbeef requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we make this a config option? This needs to be set with the scape timeout in mind. Otherwise, it's possible that scrapes just continue to build up if the interval is << the scrape latency.

@GeorgeTsagk GeorgeTsagk force-pushed the prometheus-bump-timeout branch from d734487 to 6c6bb3c Compare January 16, 2025 11:48
@GeorgeTsagk GeorgeTsagk changed the title monitoring: bump default metrics collection timeout to 120s monitoring: export collector timeout as prometheus config Jan 16, 2025
@GeorgeTsagk GeorgeTsagk force-pushed the prometheus-bump-timeout branch 4 times, most recently from 1f94bd4 to c102640 Compare January 20, 2025 09:27
guggero
guggero reviewed Jan 20, 2025
View reviewed changes
monitoring/config.go Outdated Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk force-pushed the prometheus-bump-timeout branch from c102640 to 565e4a0 Compare January 20, 2025 13:34
guggero
guggero approved these changes Jan 20, 2025
View reviewed changes
monitoring/prometheus.go Show resolved Hide resolved
monitoring/prometheus.go Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk force-pushed the prometheus-bump-timeout branch from 565e4a0 to 65679a0 Compare January 22, 2025 09:07
@GeorgeTsagk GeorgeTsagk requested review from ffranr and removed request for Roasbeef January 22, 2025 09:13
@GeorgeTsagk GeorgeTsagk enabled auto-merge January 22, 2025 10:50
@guggero guggero disabled auto-merge January 22, 2025 10:56
@guggero guggero merged commit f340f7f into lightninglabs:main Jan 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef requested changes

@ffranr ffranr ffranr approved these changes

@guggero guggero guggero approved these changes

Assignees

@GeorgeTsagk GeorgeTsagk

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GeorgeTsagk @coveralls @Roasbeef @guggero @ffranr